Skip to content

Import 3 x imaging instruments from various sources#2569

Open
willend wants to merge 31 commits into
mainfrom
import-imaging-instruments
Open

Import 3 x imaging instruments from various sources#2569
willend wants to merge 31 commits into
mainfrom
import-imaging-instruments

Conversation

@willend

@willend willend commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Free-form text area

Please describe what your PR is adding in terms of features or bugfixes:

Import of:

  • Radiography_Li_battery (Mads Bertelsen & Viktor Holm)
  • Radiography_Sword (Mads Bertelsen & Viktor Holm)
  • PSI_ICON (Peter Willendrup & Estrid B. Naver)
  • Required datafiles and a couple of new components

Declaration of use of AI-tools

  • Please add a checkmark here if you used AI-tools during the work for this contribution
  • Furter, please describe how / where and for what the tools were used:
    No AI this time round. Just me… ;-)

Development OS / boundary conditions

Please describe what OS you developed and tested your additions on, and if any special dependencies are required:

macOS Tahoe, conda-forge dev-tools


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution includes a new component file

    • I have ensured that naming of parameters are in the style of existing components. (Please check the McStas or McXtrace NOMENCLATURE docs.)
    • I have ensured that component parameters are in the usually units of McStas or McXtrace (SI + neutron/x-ray 'usual' units)
    • I have used the mcdoc utility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)
    • I have ensured that basic use of the component is OK (e.g. an instrument using it compiles?)
    • I have included a corresponding example instrument and will fill in the new instrument section below
    • I have used the mccode-clangformat tool to apply the standard McCode component indentation scheme
    • My new component is added within the contrib component category
  • My contribution includes a new instrument file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)
    • I have ensured that basic use of the instrument is OK (e.g. it compiles?)
    • ... and provided reasonable default parameters in that instrument that produce reasonable output
    • ... and maybe even added a %Example: line to describe expected behaviour
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised
    • My new instrument is added within the examples hierarchy in a folder in the style of examples/ESS/New_stuff/New_stuff.instr
    • My new instrument has a new, unique filename, not clashing with existing example instruments
    • My new instrument requires a data/input file. If the datafile is specific for my instrument I have left it in the same example folder, but if general use I have placed it in the global data folder.

@willend

willend commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Instrument Radiography_Lithium_Battery:
Screenshot 2026-07-10 at 12 51 19
Screenshot 2026-07-10 at 12 51 28
Screenshot 2026-07-10 at 13 07 02

Instrument Radiography_Sword:
Screenshot 2026-07-10 at 13 56 04
Screenshot 2026-07-10 at 13 56 09
Screenshot 2026-07-10 at 13 56 32

Instrument PSI_ICON:
Screenshot 2026-07-10 at 15 47 51
Screenshot 2026-07-10 at 15 47 57
Screenshot 2026-07-10 at 15 47 08

@willend

willend commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Component PSD_monitor_Filter:
Screenshot 2026-07-10 at 14 17 41

Component Wavelength_Diffuser:
Screenshot 2026-07-10 at 13 58 26

@willend willend requested a review from mads-bertelsen July 10, 2026 14:06
@willend

willend commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@jorobledo, @farhi here comes the 3 x imaging instruments discussed elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant