fix: emulator selection reappears after config directory deleted (PRO-349)#345
Draft
gtsiolis wants to merge 1 commit into
Draft
Conversation
Add unit test proving config.Load() returns firstRun=true when the config directory exists but config.toml is absent (e.g. after newLogger recreates the directory). Add integration test covering the full scenario: config directory deleted after successful run triggers the emulator selector on the next run. Co-authored-by: Claude <noreply@anthropic.com>
gtsiolis
force-pushed
the
pro-349-emulator-selection-prompt-does-not-reappear-after-configlstk
branch
from
69c6fff to
8c9103e
Compare
gtsiolis
added
semver patch
skip docs
semver: patch
docs: skip
Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes PRO-349
config.Load()correctly returnsfirstRun=truewhen~/.config/lstk/exists butconfig.tomlis absent (the directory-recreated-by-logger scenario does not break first-run detection)Load()returnsfirstRun=truewhen the config directory exists butconfig.tomlis missinglstk startTest plan
make test— unit testTestLoadFirstRunAfterConfigDirRecreatedpassesmake test-integration RUN=TestEmulatorSelectionReappearsAfterConfigDirDeleted— integration test passes (requires Docker)make test-integration RUN=TestEmulatorSelectionReappearsAfterFailedFirstRun— integration test passes (requires Docker)rm -rf ~/.config/lstk/ && lstk start→ emulator selection prompt appears🤖 Generated with Claude Code