Skip to content

fix: fixed preexisting tests ci failure #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rposts merged 2 commits into from
Jul 13, 2026
Merged

fix: fixed preexisting tests ci failure #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a47653
fix: fixed preexisting tests ci failure
rohansen856 Apr 19, 2026
cfffe28
Merge remote-tracking branch 'origin/main' into tests_fix
rohansen856 Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/test_script_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,12 +274,13 @@ def test_publish_with_rpm(self, mock_checksum, temp_repo_dir, mocker):
# Should call gh release twice: create + upload
assert mock_run.call_count == 2

# Verify upload call
# Verify upload call: the rpm is renamed with the distro suffix before upload
expected_rpm = os.path.join(temp_repo_dir, "test-app-1.0.0-jammy-linux-s390x.rpm")
upload_call = mock_run.call_args_list[1]
assert "upload" in upload_call[0][0]
# Normalize paths for cross-platform comparison
uploaded_file = os.path.normpath(upload_call[0][0][-1])
assert os.path.normpath(rpm_path) == uploaded_file
assert os.path.normpath(expected_rpm) == uploaded_file

@patch('lib.checksum.generate_checksum')
def test_publish_with_deb(self, mock_checksum, temp_repo_dir, mocker):
Expand All @@ -305,12 +306,13 @@ def test_publish_with_deb(self, mock_checksum, temp_repo_dir, mocker):
# Should call gh release twice: create + upload
assert mock_run.call_count == 2

# Verify upload call
# Verify upload call: the deb is renamed with the distro suffix before upload
expected_deb = os.path.join(temp_repo_dir, "test-app-1.0.0-jammy-linux-s390x.deb")
upload_call = mock_run.call_args_list[1]
assert "upload" in upload_call[0][0]
# Normalize paths for cross-platform comparison
uploaded_file = os.path.normpath(upload_call[0][0][-1])
assert os.path.normpath(deb_path) == uploaded_file
assert os.path.normpath(expected_deb) == uploaded_file

@patch('lib.checksum.generate_checksum')
def test_publish_subprocess_error(self, mock_checksum, temp_repo_dir, mocker):
Expand Down
Loading