Skip to content

feat: Git configure edit modal#1017

Merged
dennisvankekem merged 6 commits into
mainfrom
APL-1945
Jun 22, 2026
Merged

feat: Git configure edit modal#1017
dennisvankekem merged 6 commits into
mainfrom
APL-1945

Conversation

@dennisvankekem

@dennisvankekem dennisvankekem commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GET /v2/git endpoint and supporting plumbing to let the console’s “Git configure edit” modal prefill existing Git configuration values from the API.

Changes:

  • Extends SettingsInfo.otomi.git to include username, password, and email.
  • Adds OtomiStack.getGitSettings() and a new GET /v2/git operation handler.
  • Updates OpenAPI routes and ACL for AplGit to allow non-platform roles to read Git settings.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/otomi-stack.ts Adds git fields into getSettingsInfo() projection and introduces getGitSettings() helper.
src/api/v2/git.ts Adds the GET /v2/git handler that returns current git settings.
src/openapi/api.yaml Defines GET /v2/git in the API spec.
src/openapi/settingsinfo.yaml Documents additional otomi.git fields in SettingsInfo.
src/openapi/git.yaml Adjusts ACL so team roles can read AplGit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/otomi-stack.ts
Comment thread src/otomi-stack.ts
Comment thread src/api/v2/git.ts
Comment thread src/openapi/settingsinfo.yaml Outdated
Comment thread src/openapi/api.yaml
Comment thread src/openapi/git.yaml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comment thread src/openapi/git.yaml
Comment thread src/openapi/api.yaml
Comment thread src/api/v2/git.ts

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comment thread src/openapi/api.yaml
Comment thread src/otomi-stack.ts

@j-zimnowoda j-zimnowoda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennisvankekem dennisvankekem merged commit 86d00c0 into main Jun 22, 2026
9 checks passed
@dennisvankekem dennisvankekem deleted the APL-1945 branch June 22, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants