Skip to content

build: fix dependency security alerts#1175

Draft
starius wants to merge 1 commit into
lightninglabs:masterfrom
starius:bump-for-dependabot
Draft

build: fix dependency security alerts#1175
starius wants to merge 1 commit into
lightninglabs:masterfrom
starius:bump-for-dependabot

Conversation

@starius

@starius starius commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Postgres client was bumped to pgx v5 to go away from archived versions.

Tested this manually in regtest on all swap types - everything is green.

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses security vulnerabilities by upgrading the Postgres client to pgx v5. It includes comprehensive updates to the project's dependency tree, including minor version bumps and removals of deprecated packages. Additionally, it refines the default configuration for connecting to the daemon and introduces a temporary go.mod replacement to bridge the gap until the required lnd version is released.

Highlights

  • Dependency Security: Upgraded the Postgres client to pgx v5 to move away from archived versions and mitigate security alerts.
  • Configuration Updates: Updated default configuration logic to correctly resolve the TLS path using the application data directory.
  • Dependency Management: Performed a broad update of project dependencies and added a temporary replacement for sqldb to ensure the pgx v5 migration is properly handled.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the legacy pgx v4 and pgproto3 dependency chain by migrating to pgx v5 and replacing the lnd/sqldb dependency with a newer revision. It also updates several other Go dependencies and refactors assets/client.go to avoid importing tapcfg by constructing default paths manually. However, setting MacaroonPath to an empty string in DefaultTapdConfig will cause client initialization to fail immediately when it attempts to read the macaroon file. It is recommended to default to the mainnet admin macaroon path instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread assets/client.go
Host: "localhost:10029",
MacaroonPath: defaultConf.RpcConf.MacaroonPath,
TLSPath: defaultConf.RpcConf.TLSCertPath,
MacaroonPath: "",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Setting MacaroonPath to "" by default will cause NewTapdClient(DefaultTapdConfig()) to fail immediately because getClientConn unconditionally attempts to read the macaroon file using os.ReadFile(config.MacaroonPath). Since mainnet is the default network for tapd, we should default to the mainnet admin macaroon path.

Suggested change
MacaroonPath: "",
MacaroonPath: filepath.Join(defaultTapdDir, "mainnet", "admin.macaroon"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant