docs: remove stale README sections and sample permission#677
Merged
Conversation
- Remove the ProGuard section: the published AAR already bundles consumer ProGuard rules with the same keep rules, so manual setup is redundant. - Update Transitive Dependencies example from Glide to Coil, matching the SDK's current image-loading dependency. - Remove READ_EXTERNAL_STORAGE guidance: deprecated/ignored for media since Android 13, and the SDK no longer declares it. - Drop READ_EXTERNAL_STORAGE from the sample app manifest for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
DD-Intercom
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cleans up outdated/redundant content in the README, verified against the actually published SDK AAR (not just the repo docs).
intercom-sdk-baseAAR already bundles a consumerproguard.txtcontaining the exact keep rules the README told users to add manually (-keep class io.intercom.android.**,-keep class com.intercom.**) plus additional-dontwarn/-keeprules. AAR consumer rules are auto-merged into the consuming app's R8 config, so the manual instructions were redundant. The OkHttp/Okio/Retrofit note was also stale.READ_EXTERNAL_STORAGEguidance. Deprecated/ignored for media since Android 13 (API 33), and the SDK AAR no longer declares it. Kept the accurate INTERNET and VIBRATE subsections.READ_EXTERNAL_STORAGEfrom the sample app manifest for consistency.Left unchanged (verified accurate)
Testing
Docs + manifest only — no code or build changes.
🤖 Generated with Claude Code