symbolizer: Add success tests and clean up tests#5359
Merged
Conversation
Adds a new test for llvm-symbolizer successfully symbolizing a normal stack trace and one for frames that return multiple frames. Also refactors the crashing mock to more closely match a real crashing llvm-symbolizer i.e. succeeding for the first frame but crashing when symbolizing the second line.
g-ortuno
force-pushed
the
symbolizer-tests
branch
from
bea1565 to
b5d5ad8
Compare
Collaborator
Author
|
@dylanjew : PTAL! |
dylanjew
approved these changes
Jul 14, 2026
Collaborator
Author
|
@ViniciustCosta : PTAL! This PR just adds/improves testing. |
dylanjew
approved these changes
Jul 14, 2026
ViniciustCosta
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new test for llvm-symbolizer successfully symbolizing a normal stack trace and one for frames that return multiple frames.
Also refactors the crashing mock to more closely match a real crashing llvm-symbolizer i.e. succeeding for the first frame but crashing when symbolizing the second line.