Correct execution permission check 100 -> 0o100#5353
Merged
Conversation
dylanjew
approved these changes
Jul 8, 2026
dylanjew
approved these changes
Jul 8, 2026
ViniciustCosta
approved these changes
Jul 14, 2026
ViniciustCosta
left a comment
ViniciustCosta
left a comment
Collaborator
There was a problem hiding this comment.
Seems like a nice catch to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bitwise check for
needs_execute_permissionuses decimal 100 (0o144) instead of octal 100 to determine if execution permissions would be needed. This results in giving execution permissions to files that had read permissions in group or others (---r--r--).Corrected this bug by switching to
0o100and added unit tests to better check which files receive execution permissions.Bug: https://crbug.com/531741750