Multi container registry support#185
Conversation
Centralize most of the logic for getting an auth token and adding it to the request in preparation for supporting container registries without authentication.
Docker Hub remains the only implemented registry, but this allows it to work with registry.k8s.io. Ideally the authURL would not be hardcoded per registry but be discovered from the registry's response headers.
|
@andrew This already works for registry.k8s.io because it requires no authentication. I haven't added any tests or configuration yet, but is this a general direction you'd accept? Also CONTRIBUTING.md didn't say whether you prefer multi-commit PRs or stacked PRs. |
|
The auth parts of this might have to change depending on #186 |
|
I found @kpfleming approach of making it configurable much better: |
|
@markkrj Do you mean just the fact that it's configurable? As I said in my initial PR description, configuration is still missing. This is a prototype to gather feedback on the basic idea. |
|
The Two things worth settling early:
Otherwise, this looks like a useful prototype to continue developing. |
for #56
Open issues:
registry.k8s.io/kube-apiserverbecomescache/artifacts/oci/kube-apiserver