experiment(derived data): Add decorator for merged groups#118533
Draft
ceorourke wants to merge 2 commits into
Draft
experiment(derived data): Add decorator for merged groups#118533ceorourke wants to merge 2 commits into
ceorourke wants to merge 2 commits into
Conversation
ceorourke
commented
Jun 25, 2026
| def _track_progress_merged(state: StateView, entry: GroupActionLogEntry) -> AggregatorResult: | ||
| # ASSIGN advances progress the same way regardless of which group it came | ||
| # from, so merged-in assignments fall through to the default behavior. | ||
| if entry.type == GroupActionType.ASSIGN: |
Member
Author
There was a problem hiding this comment.
add to this for whichever other ones will share this behavior
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a decorator to indicate that we want to have different behavior for merged groups - in some cases we want the default behavior (use whatever is most recent) and in some cases we may want to prioritize the non-merged group's log over the merged in ones. This tries out a way of accomplishing that for the case where each group is assigned to a different user/team and the case where each group has set a different priority.