Skip to content

feat(data-collection): foundation — option, resolution, accessors#6676

Draft
ericapisani wants to merge 1 commit into
masterfrom
ep/db-spec-experiment-foundation
Draft

feat(data-collection): foundation — option, resolution, accessors#6676
ericapisani wants to merge 1 commit into
masterfrom
ep/db-spec-experiment-foundation

Conversation

@ericapisani

Copy link
Copy Markdown
Member

Introduces the data_collection init option, A/B/C/D resolution precedence, and the should_collect_* accessors plus the scrubbing primitives (with unit tests).

Behavior-neutral: in legacy mode the resolved DataCollection mirrors send_default_pii, and nothing consumes the new filtering yet — so merging this changes no observed behavior.

Base of the data_collection split. Consumers stack on top:

  • frames (stack-frame variables + source context lines)
  • http (request data collection)
  • genai (AI input/output collection)

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

90796 passed | ⏭️ 6305 skipped | Total: 97101 | Pass Rate: 93.51% | Execution Time: 313m 25s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +645
Passed Tests 📈 +645
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 88.50%. Project has 2419 uncovered lines.
✅ Project coverage is 89.94%. Comparing base (base) to head (head).

Files with missing lines (3)
File Patch % Lines
sentry_sdk/data_collection.py 90.37% ⚠️ 18 Missing and 14 partials
sentry_sdk/client.py 86.67% ⚠️ 4 Missing and 1 partials
sentry_sdk/scope.py 50.00% ⚠️ 4 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.92%    89.94%    +0.02%
==========================================
  Files          192       193        +1
  Lines        23809     24035      +226
  Branches      8218      8314       +96
==========================================
+ Hits         21409     21616      +207
- Misses        2400      2419       +19
- Partials      1339      1354       +15

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant