feat(node): Wire up SentryTracerProvider#21680
Open
andreiborza wants to merge 3 commits into
Open
Conversation
andreiborza
requested review from
JPeer264 and
mydea
and removed request for
a team
Contributor
size-limit report 📦
|
andreiborza
changed the title
andreiborza
force-pushed
the
ab/sentry-trace-provider-node
branch
from
e05567e to
dc3cd9d
Compare
andreiborza
force-pushed
the
ab/sentry-trace-provider-otel
branch
from
7f2f88d to
172dd9f
Compare
andreiborza
force-pushed
the
ab/sentry-trace-provider-node
branch
from
dc3cd9d to
f3c0c65
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
nicohrubec
reviewed
Jun 22, 2026
| coreDebug.warn( | ||
| 'Could not register SentryTracerProvider because another OpenTelemetry tracer provider is already registered.', | ||
| ); | ||
| return [undefined, undefined]; |
Member
There was a problem hiding this comment.
m: is this in a good state if the setup fails here? we won't install the sentry propagator and context manager in here and then we also bail early in the main setupOtel method but we already set up the otel async context strategy. might be fine just checking
| ): [BasicTracerProvider, AsyncLocalStorageLookup] { | ||
| ): [OpenTelemetryTraceProvider | undefined, AsyncLocalStorageLookup | undefined] { | ||
| if (client.getOptions()._experiments?.useSentryTracerProvider) { | ||
| setOpenTelemetryContextAsyncContextStrategy(); |
Member
There was a problem hiding this comment.
m: do we even need to call this here? setupOtel is called from initOpenTelemetry, which is called in the node init after we make the node-core init which also makes this same call:
andreiborza
force-pushed
the
ab/sentry-trace-provider-otel
branch
from
172dd9f to
afb77ef
Compare
andreiborza
force-pushed
the
ab/sentry-trace-provider-node
branch
from
e200c8f to
502dca9
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
andreiborza
force-pushed
the
ab/sentry-trace-provider-otel
branch
from
afb77ef to
fcdf2df
Compare
andreiborza
force-pushed
the
ab/sentry-trace-provider-node
branch
from
502dca9 to
6ae8302
Compare
andreiborza
force-pushed
the
ab/sentry-trace-provider-otel
branch
from
fcdf2df to
40d8abc
Compare
Add the SentryTracerProvider under an experimental `useSentryTracerProvider` flag and update the node setup path to register the new TracerProvider and its async context strategy instead of the full OTel SDK tracer provider when enabled.
Lift `http.response.status_code` into the top-level `response` context inside the HTTP server-spans integration's `processEvent`, where the value is already read for status-code filtering. This covers transactions produced by the `SentryTracerProvider` (which bypasses the OTel SDK span exporter), so the provider's `preprocessEvent` hook no longer needs to set it. The OTel SDK span exporter keeps setting the same value on its path; both derive the status code from the same span attribute, so the duplicate write is a harmless idempotent overwrite. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/sentry-trace-provider-otel
branch
from
2c670f3 to
308e560
Compare
andreiborza
force-pushed
the
ab/sentry-trace-provider-node
branch
from
6ae8302 to
e2f91c0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e2f91c0. Configure here.
|
|
||
| setGlobalSpy.mockRestore(); | ||
| setIsSetupSpy.mockRestore(); | ||
| }); |
There was a problem hiding this comment.
SentryTracerProvider tests skip OTel teardown
Medium Severity
New OpenTelemetry tests register SentryTracerProvider, but shared afterEach cleanup only shuts down BasicTracerProvider. Global tracer state can leak between tests and make later init calls fail or behave inconsistently.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit e2f91c0. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires up the node SDK to use
SentryTracerProviderwhen_experiments.useSentryTracerProvideris enabled (default opt-in).When enabled, it uses our SentryTracerProvider and async context strategy instead of the Otel SDK's.
For simplicity, a flag is used, but we could change this to be an explicit call (+ a flag to opt out of the current tracer provider) to save some bundle size.