Skip to content

Fix broken link to run_app_with_gemini_key.md in examples READMEs#854

Closed
omarfarouk228 wants to merge 1 commit into
flutter:mainfrom
omarfarouk228:fix/broken-link-gemini-key-docs
Closed

Fix broken link to run_app_with_gemini_key.md in examples READMEs#854
omarfarouk228 wants to merge 1 commit into
flutter:mainfrom
omarfarouk228:fix/broken-link-gemini-key-docs

Conversation

@omarfarouk228

Copy link
Copy Markdown

Description

Fixes #783
The file was moved to docs/usage/ but the links in two example READMEs still pointed to the old path, causing a 404.

Fixed in:

  • examples/travel_app/README.md
  • examples/simple_chat/README.md

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes broken links to the run_app_with_gemini_key.md documentation in the simple_chat and travel_app example READMEs and updates the genui package changelog. I have no feedback to provide.

Note: Security Review has been skipped due to the limited scope of the PR.

@Piinks Piinks requested review from Piinks and removed request for Piinks June 22, 2026 22:08
@polina-c

Copy link
Copy Markdown
Collaborator

Thank you for suggestion.

Can you please, fix the conflicts?

@omarfarouk228 omarfarouk228 force-pushed the fix/broken-link-gemini-key-docs branch from 89ad2e8 to 76f4ea1 Compare June 30, 2026 01:49
@omarfarouk228

Copy link
Copy Markdown
Author

I fixed the conflicts @polina-c

@github-actions

Copy link
Copy Markdown

Package publishing

If you have publishing permissions, you can use the links below to publish the changes after merging this PR.

Package Version Status Publish tag (post-merge)
package:a2ui_core 0.0.1-wip002 ready to publish a2ui_core-v0.0.1-wip002
package:genai_primitives 0.2.4 ready to publish genai_primitives-v0.2.4
package:genui 0.9.2 (error) pubspec version (0.9.2) and changelog (0.10.0) don't agree
package:genui_a2a 0.9.0 (error) pubspec version (0.9.0) and changelog (0.10.0) don't agree
package:json_schema_builder 0.1.5 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@polina-c

Copy link
Copy Markdown
Collaborator

It seems the broken links were already fixed previously. But thank you for noticing and submitting the fix. Highly appreciate it.

@jacobsimionato

Copy link
Copy Markdown
Collaborator

Yes, thanks! I'm going to close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

broken link in read me on examples/travel_app

3 participants