fix(auto_submit): Pass requestSha to GitHub merge API#5107
Merged
Conversation
Defense in depth - prevent autosubmit from trying to land a pushed (but not approved) pr. This is not a real issue since we have branch protection rules, but it's good to have.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the validation service to require and validate the head SHA when merging a pull request directly. It also adds corresponding tests and updates the fake GitHub service to track merge SHAs. The review feedback correctly points out that when direct merging fails due to an invalid head SHA, the returned SubmitMethod should be SubmitMethod.merge instead of SubmitMethod.enqueue.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
jtmcdole
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defense in depth - prevent autosubmit from trying to land a pushed (but not approved) pr.
This is not a real issue since we have branch protection rules, but it's good to have.