Skip to content

fix(ci): harden some workflows in cocoon#5106

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
jtmcdole:zizmor
Jul 15, 2026
Merged

fix(ci): harden some workflows in cocoon#5106
auto-submit[bot] merged 2 commits into
flutter:mainfrom
jtmcdole:zizmor

Conversation

@jtmcdole

Copy link
Copy Markdown
Member

fixes flutter/flutter#189097

➜  /app /opt/zizmor --gh-token=$(gh auth token) .github/workflows
 INFO zizmor: 🌈 zizmor v1.25.2
 INFO audit: zizmor: 🌈 completed .github/workflows/app_dart_tests.yaml
 INFO audit: zizmor: 🌈 completed .github/workflows/common_validation.yaml
 INFO audit: zizmor: 🌈 completed .github/workflows/dashboard_tests.yaml
 INFO audit: zizmor: 🌈 completed .github/workflows/packages_checks.yaml
No findings to report. Good job! (13 suppressed)
➜  /app /opt/zizmor --gh-token=$(gh auth token) packages/wait_for_tests
 INFO zizmor: 🌈 zizmor v1.25.2
 INFO audit: zizmor: 🌈 completed packages/wait_for_tests/action.yml
No findings to report. Good job! (1 suppressed)

fixes flutter/flutter#189097

```
➜  /app /opt/zizmor --gh-token=$(gh auth token) .github/workflows
 INFO zizmor: 🌈 zizmor v1.25.2
 INFO audit: zizmor: 🌈 completed .github/workflows/app_dart_tests.yaml
 INFO audit: zizmor: 🌈 completed .github/workflows/common_validation.yaml
 INFO audit: zizmor: 🌈 completed .github/workflows/dashboard_tests.yaml
 INFO audit: zizmor: 🌈 completed .github/workflows/packages_checks.yaml
No findings to report. Good job! (13 suppressed)
➜  /app /opt/zizmor --gh-token=$(gh auth token) packages/wait_for_tests
 INFO zizmor: 🌈 zizmor v1.25.2
 INFO audit: zizmor: 🌈 completed packages/wait_for_tests/action.yml
No findings to report. Good job! (1 suppressed)
```
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 15, 2026
@jtmcdole
jtmcdole requested a review from eyebrowsoffire July 15, 2026 19:34

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the packages/wait_for_tests/action.yml composite action. It pins the dart-lang/setup-dart dependency to a specific commit SHA for enhanced security. Additionally, it refactors the action to pass the resolved action path between steps using step outputs ($GITHUB_OUTPUT) instead of modifying the global environment ($GITHUB_ENV). There are no review comments, and the changes are clean and follow best practices.

@jtmcdole jtmcdole closed this Jul 15, 2026
@jtmcdole jtmcdole reopened this Jul 15, 2026
@fluttergithubbot

Copy link
Copy Markdown

An existing Git SHA, 46215f537c093d7c10c7ad004085a17876b61246, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@jtmcdole

Copy link
Copy Markdown
Member Author

That is not the button I meant to press...

@eyebrowsoffire eyebrowsoffire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks pretty straightforward! Just one nitpick but otherwise LGTM

Comment thread .github/workflows/dashboard_tests.yaml Outdated
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App. label Jul 15, 2026
@auto-submit
auto-submit Bot merged commit a86ab14 into flutter:main Jul 15, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: harden cocoon workflow actions with zizmor

3 participants