Add host name template types, activity, and validation#48699
Conversation
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
WalkthroughThis PR adds host name template functionality to Fleet. It introduces Sequence Diagram(s)Not applicable — this PR primarily adds data validation/resolution logic and type definitions rather than a new interactive request/response flow. Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 38806-macos-iosipados-rename-hosts #48699 +/- ##
=====================================================================
Coverage ? 67.99%
=====================================================================
Files ? 3680
Lines ? 233873
Branches ? 12268
=====================================================================
Hits ? 159025
Misses ? 60518
Partials ? 14330
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Relates to #48621 - Add name_template to TeamMDM, TeamSpecMDM and TeamPayloadMDM. - Add the edited_host_name_template activity type. - Add ValidateHostNameTemplate and ResolveHostNameTemplate in server/fleet/name_template.go.
f8213c0 to
45eb941
Compare
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
lucasmrod
left a comment
There was a problem hiding this comment.
LGTM! Left two comments/questions.
b89bc70
into
38806-macos-iosipados-rename-hosts
Related issue: Relates to #48621
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Testing
Summary by CodeRabbit
New Features
Bug Fixes