Add required memory functions for non-gradient boosted equivalent sources#689
Merged
Conversation
santisoler
requested changes
Jul 8, 2026
santisoler
left a comment
santisoler
left a comment
Member
There was a problem hiding this comment.
It looks good to me, @mdtanker! Thanks for adding this, I get how helpful it can be.
I left a few small suggestions to the docs, feel free to check them out.
Also, I fixed tests failing in Harmonica, so if you update the branch, your tests should pass now.
Thanks again!
Co-authored-by: Santiago Soler <santisoler@fastmail.com>
santisoler
approved these changes
Jul 14, 2026
santisoler
left a comment
santisoler
left a comment
Member
There was a problem hiding this comment.
All good, @mdtanker. Just spotted a minor thing in the tests for spherical coordinates. Feel free to merge after addressing those! 🚀
Co-authored-by: Santiago Soler <santisoler@fastmail.com>
Co-authored-by: Santiago Soler <santisoler@fastmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find I commonly want to check whether I can fit a jacobian in memory for regular (non-gradient boosted) equivalent sources, but have no easy way to check whether this is true, of if I need to switch to gradient boosted. This PR adds equivalent
estimate_required_memoryfunctions for cartesian and spherical equivalent sources.