Skip to content

Include bitstring in domain keys#15516

Merged
josevalim merged 1 commit into
elixir-lang:mainfrom
lukaszsamson:ls-bitstring-domain
Jun 23, 2026
Merged

Include bitstring in domain keys#15516
josevalim merged 1 commit into
elixir-lang:mainfrom
lukaszsamson:ls-bitstring-domain

Conversation

@lukaszsamson

Copy link
Copy Markdown
Contributor

Fixes #15515

Assisted-by: Tests written by Claude Opus 4.8

@josevalim

Copy link
Copy Markdown
Member

@lukaszsamson the types on the domain keys should be distinct, they cannot overlap. So we'd need to introduce bitstring_no_binary as the key and for bitstrings, we set both keys.

@josevalim

Copy link
Copy Markdown
Member

Oh, ignore me, this is already how it is handled. I will merge this tomorrow and clean it up later.

@josevalim josevalim merged commit 1d3a5b8 into elixir-lang:main Jun 23, 2026
12 of 13 checks passed
@josevalim

Copy link
Copy Markdown
Member

💚 💙 💜 💛 ❤️

josevalim pushed a commit that referenced this pull request Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

bitstring domain missing from @domain_key_types

2 participants