Cosmos: run query response status checks inside execution strategy retries

[Copilot]

Fixes #38032

Cosmos queries could surface transient 410 Gone (PartitionKeyRangeGone / substatus 1002) during partition splits because EnsureSuccessStatusCode() was executed outside EF’s retry boundary for stream-based query paths. As a result, transient response-status failures were not retried even though the execution strategy treats Gone as retryable.

• Retry boundary correction (stream query path)

  • Updated CosmosClientWrapper.DocumentAsyncEnumerable.AsyncEnumerator.MoveNextAsync so ReadNextAsync and EnsureSuccessStatusCode() execute within _executionStrategy.ExecuteAsync(...).
  • On failure, the ResponseMessage is disposed before rethrow to avoid leaking failed-attempt responses across retries.

• Retry boundary + iterator recreation correction (paging query path)

  • Updated PagingQueryingEnumerable.AsyncEnumerator.MoveNextAsync to run ReadNextAsync + EnsureSuccessStatusCode() under _cosmosQueryContext.ExecutionStrategy.ExecuteAsync(...).
  • Moved CreateQuery(...) inside the retry delegate so each retry attempt uses a new FeedIterator.
  • Retries now execute with the current continuation token as strategy state, ensuring retries resume from the last successful page and avoid replaying already-returned results.
  • Added the same failure-path disposal behavior for ResponseMessage.

• Regression coverage

  • Existing unit coverage in CosmosClientWrapperTest verifies transient Gone status is retried for stream query execution.
  • Added a paging-focused regression test (ToPageAsync_retries_with_new_feed_iterator_from_last_successful_continuation_token) that simulates:
    1. first page success with continuation token,
    2. transient Gone on next-page read,
    3. retry with a recreated iterator using the same continuation token.
  • Verifies no duplicate results are returned across the retry boundary.

_responseMessage = await _executionStrategy.ExecuteAsync(
    _query,
    static async (_, query, ct) =>
    {
        var response = await query.ReadNextAsync(ct).ConfigureAwait(false);
        try
        {
            response.EnsureSuccessStatusCode();
        }
        catch
        {
            response.Dispose();
            throw;
        }

        return response;
    },
    null,
    cancellationToken).ConfigureAwait(false);

[Copilot]

Pull request overview

This PR adjusts Cosmos query execution so that ResponseMessage.EnsureSuccessStatusCode() runs inside EF Core’s execution-strategy retry boundary for stream-based and paging query paths, allowing transient 410 Gone responses (e.g., during partition splits) to be retried correctly.

Changes:

• Wrapped ReadNextAsync + EnsureSuccessStatusCode() in _executionStrategy.ExecuteAsync(...) for the stream query enumerator (CosmosClientWrapper).
• Wrapped paging ReadNextAsync + EnsureSuccessStatusCode() in the paging enumerator’s execution strategy, and moved iterator creation into the retry delegate to ensure a fresh FeedIterator per attempt.
• Added/extended Cosmos unit tests to validate retries and that paging retries resume from the last successful continuation token without duplicating results.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
test/EFCore.Cosmos.Tests/Storage/Internal/CosmosClientWrapperTest.cs	Adds regression tests and helper iterators/messages to validate retry behavior for stream and paging query paths.
src/EFCore.Cosmos/Storage/Internal/CosmosClientWrapper.cs	Moves response status validation inside the execution strategy for the stream query enumerator and disposes failed responses before retry.
src/EFCore.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.PagingQueryingEnumerable.cs	Ensures paging reads + status validation happen inside execution strategy retries and recreates FeedIterator per retry attempt using the current continuation token.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.