Remove dependency to Microsoft.DotNet.PlatformAbstractions.#3190
Merged
Conversation
filzrev
reviewed
Jul 6, 2026
| string operatingSystem = RuntimeEnvironment.OperatingSystem; | ||
| string operatingSystemVersion = RuntimeEnvironment.OperatingSystemVersion; | ||
| string operatingSystem = OSDescription; | ||
| string operatingSystemVersion = Environment.OSVersion.ToString(); |
Contributor
There was a problem hiding this comment.
These APIs do not seem to be compatible.
Microsoft.DotNet.PlatformAbstractions APIs returns following outputs.
- Windows
- 10.0.26200
In contrast, replaced API returns following outputs.
- Microsoft Windows 10.0.26200
- Microsoft Windows NT 6.2.9200.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft.DotNet.PlatformAbstractionsis a package that no longer receives updates since .NET 5. This PR removes this dependency from BenchmarkDotNet, and replaces its usage with built-in APIs.