chore(nuxt): use tsdown/package.json to update builder version at module.json#33
Open
userquin wants to merge 1 commit into
Open
chore(nuxt): use tsdown/package.json to update builder version at module.json#33userquin wants to merge 1 commit into
tsdown/package.json to update builder version at module.json#33userquin wants to merge 1 commit into
Conversation
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Nuxt package build hook to record the installed tsdown version in generated module metadata instead of using the version range from devDependencies.
Changes:
- Read
tsdown’s package version fromtsdown/package.json - Remove reliance on
devDependencies.tsdownwhen generating the module JSON
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+45
to
+46
| const tsdownPkg = require('tsdown/package.json') | ||
| const { name, version } = require('./package.json') |
Contributor
Author
There was a problem hiding this comment.
this is at build time in the repo here
| "version": "${version}", | ||
| "builder": { | ||
| "tsdown": "${devDependencies.tsdown}" | ||
| "tsdown": "${tsdownPkg.version}" |
Contributor
Author
There was a problem hiding this comment.
this is at build time in the repo here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix applied in this PR at VueUse: vueuse/vueuse#5503