Normalize Compose service additional contexts in bake#523
Merged
Conversation
PedroGuerraPT
marked this pull request as ready for review
June 30, 2026 10:11
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
goller
approved these changes
Jul 1, 2026
Contributor
Author
|
@BugBot review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 138f26b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
additional_contextsvalues likeservice:api.docsinto generated bake target links liketarget:api_docs.Test plan
GOCACHE=/private/tmp/go-cache go test ./pkg/buildx/bakeSupport thread: T-9318
Note
Low Risk
Scoped to compose bake target generation and additional context mapping; behavior change only affects
service:additional context values.Overview
Compose-to-bake conversion now rewrites
additional_contextsentries that reference another service (e.g.service:api.docs) into baketarget:links that match sanitized target names (e.g.target:api_docs). Path and other non-service values are left unchanged.Service-to-target naming is built once via
composeBuildTargetNamesand reused when emitting targets, so linked contexts stay consistent with how compose services become bake targets (including dot-to-underscore sanitization). A regression test covers a service-linked context plus a local path context.Reviewed by Cursor Bugbot for commit 138f26b. Bugbot is set up for automated code reviews on this repo. Configure here.