fix: TypeError when passing timezone-aware datetime to until()#657
Open
koteshyelamati wants to merge 1 commit into
Open
fix: TypeError when passing timezone-aware datetime to until()#657koteshyelamati wants to merge 1 commit into
koteshyelamati wants to merge 1 commit into
Conversation
Passing a timezone-aware datetime to until() raises TypeError because the validation check compared an aware cancel_after against a naive datetime.datetime.now(), and _is_overdue() made the same mistake when checking job.run() and _schedule_next_run(). Fix until() to call datetime.now(tz=cancel_after.tzinfo) when cancel_after is timezone-aware, and fix _is_overdue() to localize the native `when` argument before comparison when cancel_after carries tzinfo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Passing a timezone-aware
datetimetojob.until()raisesTypeError: can't compare offset-naive and offset-aware datetimesin two places:until()comparesself.cancel_after(aware) againstdatetime.datetime.now()(naive)._is_overdue()compares the naivewhenargument against the awareself.cancel_after.Reproduction
Fix
until(): compare againstdatetime.datetime.now(tz=self.cancel_after.tzinfo)whencancel_afteris timezone-aware._is_overdue(): localize the naivewhenviaastimezone()before comparing, whencancel_aftercarries tzinfo.