Add ignore js flag to format subcommand#2227
Open
andres-lowrie wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
andres-lowrie
force-pushed
the
format-ignore-js-2
branch
from
July 18, 2026 20:42
a29f0e3 to
1b5693c
Compare
apilaskowski
requested changes
Jul 20, 2026
| format: `format [${projectDirMustExistOption.name}]`, | ||
| description: "Format the dataform project's files.", | ||
| positionalOptions: [projectDirMustExistOption], | ||
| options: [ |
Collaborator
There was a problem hiding this comment.
I think we should add fmtIgnoreJsOptionName to the options list for the format subcommand builder.
| ], | ||
| processFn: async argv => { | ||
| let actions = ["{definitions,includes}/**/*.{js,sqlx}"]; | ||
| const extensions = argv[fmtIgnoreJsOptionName.name] ? "*.sqlx" : "*.{js,sqlx}" |
| }, | ||
| }; | ||
|
|
||
| const fmtIgnoreJsOptionName: INamedOption<yargs.Options> = { |
Collaborator
There was a problem hiding this comment.
Lets drop Name suffix for consistency. Options generally have option suffix, while name is generally used for strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated for latest changes (from #1349)
Allows users to only format
.sqlxfiles in case they use different formatters for js files.