[simd.math,simd.reductions] Fix undeclared identifiers in std::simd#9145
Open
abhinavagarwal07 wants to merge 2 commits into
Open
[simd.math,simd.reductions] Fix undeclared identifiers in std::simd#9145abhinavagarwal07 wants to merge 2 commits into
abhinavagarwal07 wants to merge 2 commits into
Conversation
Two adjacent std::simd specifications name an identifier introduced nowhere in the enclosing itemdescr: - [simd.math]: the exposition-only modf-vec helper sizes its staging array with Ret::size(), but the only Let-bound vector type here is V; Ret is a leftover from frexp-vec (where Ret is bound). Use V::size(). - [simd.reductions]: masked reduce_max returns numeric_limits<V::value_type>::lowest(), but its template head only introduces T and Abi (no V). Use numeric_limits<T>::lowest(), matching masked reduce_min and scalar reduce_max.
jensmaurer
reviewed
Jun 17, 2026
Member
There was a problem hiding this comment.
This also needs names "x" and "mask", right?
Contributor
There was a problem hiding this comment.
Can we get these fixes in the same PR by any chance?
| \returns | ||
| If \tcode{none_of(mask)} is \tcode{true}, returns | ||
| \tcode{numeric_limits<V::value_type>::lowest()}. | ||
| \tcode{numeric_limits<T>::lowest()}. |
Member
There was a problem hiding this comment.
This looks correct. @mattkretz , please have a look.
mattkretz
reviewed
Jun 17, 2026
mattkretz
left a comment
mattkretz
left a comment
Member
There was a problem hiding this comment.
LGTM except for the (pre-existing) missing x and mask.
| \returns | ||
| If \tcode{none_of(mask)} is \tcode{true}, returns | ||
| \tcode{numeric_limits<V::value_type>::lowest()}. | ||
| \tcode{numeric_limits<T>::lowest()}. |
jensmaurer
approved these changes
Jun 17, 2026
…uce_max The masked reduce_min and reduce_max declarations leave both parameters unnamed, but their Returns elements refer to x and mask. Name the parameters x and mask so the declarations match their descriptions.
abhinavagarwal07
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix undeclared identifiers in
std::simdwording: useV::size()inmodf-vecandTin maskedreduce_max. Also name the previously unnamedxandmaskparameters in the maskedreduce_min/reduce_maxdeclarations so they match their Returns descriptions.