Add control plane reference teardown instructions#22
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a "Teardown" section to the AWS deployment documentation, detailing the step-by-step process to delete a Connect deployment. It also adds a force_destroy configuration option to the S3 bundle bucket Terraform/Terragrunt files to facilitate the deletion of non-empty buckets. The reviewer feedback highlights a missing step to upgrade/re-apply the ExternalDNS controller after editing its configuration, and suggests minor formatting and grammatical corrections in the documentation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| To delete a Connect deployment deployed using this reference stack, perform the following actions in order: | ||
|
|
||
| 1. Edit the ExternalDNS controller's [values.yaml](./k8s/controllers/external-dns/values.yaml) to set `policy: sync`, so that it is able to delete the DNS records it created for SPIRE and Connect load balancers, then re-run [install.sh](./k8s/controllers/external-dns/install.sh). |
There was a problem hiding this comment.
Shall we just set that as the default to begin with?
There was a problem hiding this comment.
I'd say so but assumed you'd added this comment due to some prior bad experience? Or did the 🤖 add that one?
There was a problem hiding this comment.
I recall the clanker added that, and I wondered about how accurate it was, but decided that it wasn't worth digging into further.
Given the default in https://kubernetes-sigs.github.io/external-dns/latest/docs/flags/ is actually sync
Modify how DNS records are synchronized between sources and providers (default: sync, options: sync, upsert-only, create-only)
and I'm pretty sure that's how I was previously running it in production (it's one of those you setup and don't really touch) I think lets change to simplify here?
I reckon this came from some tutorial or such in Claude's training data / it being conservative
Co-authored-by: Alec Wilson <alec-w@users.noreply.github.com>
No description provided.