Skip to content

chore: make GENERATED_DIAGRAMS_REPO configurable via env var#23380

Open
ebembi-crdb wants to merge 2 commits into
mainfrom
stanley/validate-branch-env-var
Open

chore: make GENERATED_DIAGRAMS_REPO configurable via env var#23380
ebembi-crdb wants to merge 2 commits into
mainfrom
stanley/validate-branch-env-var

Conversation

@ebembi-crdb

Copy link
Copy Markdown
Contributor

Summary

  • Makes the GENERATED_DIAGRAMS_REPO constant in validate_branch_existence.py configurable via an environment variable
  • Default remains cockroachdb/generated-diagrams (that repo is not moving orgs)
  • Provides flexibility if the repo location ever changes in the future

Part of Project Stanley (EDUENG-720, Ticket 5).

Test plan

  • Verify validate_branch_existence.py still resolves branches correctly with the default value
  • Test overriding GENERATED_DIAGRAMS_REPO env var to confirm it's picked up

🤖 Generated with Claude Code

Allows the generated-diagrams repo reference in
validate_branch_existence.py to be overridden via the
GENERATED_DIAGRAMS_REPO environment variable. Defaults to
`cockroachdb/generated-diagrams` (unchanged behavior since that
repo is not moving).

Part of Project Stanley (EDUENG-720, Ticket 5).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ebembi-crdb
ebembi-crdb requested a review from a team as a code owner May 21, 2026 15:27
@netlify

netlify Bot commented May 21, 2026

Copy link
Copy Markdown

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 09775e2
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/6a145b4ef14ffb0008b4e06a

@netlify

netlify Bot commented May 21, 2026

Copy link
Copy Markdown

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 09775e2
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6a145b4eb6436600089d635f

@github-actions

Copy link
Copy Markdown

Files changed:

  • .github/scripts/validate_branch_existence.py

@netlify

netlify Bot commented May 21, 2026

Copy link
Copy Markdown

Deploy Preview for cockroachdb-docs canceled.

Name Link
🔨 Latest commit 09775e2
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6a145b4ee163d400088439ce

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ebembi-crdb
ebembi-crdb requested a review from mohini-crl May 25, 2026 14:28
Sonichigo pushed a commit to Sonichigo/docs-1 that referenced this pull request Jul 21, 2026
Consolidates PRs cockroachdb#23378, cockroachdb#23379, cockroachdb#23380, cockroachdb#23406 into a single branch.

- Update all cockroachdb/docs GitHub URLs to cockroachlabs/docs across
  configs, workflows, templates, vale rules, and content files
- Add NETLIFY_SITE_NAME env var for Netlify preview URLs (default:
  cockroachlabs-docs)
- Add DOCS_ORG env var for GitHub org in docs-prs-reviews.go (default:
  cockroachlabs)
- Make GENERATED_DIAGRAMS_REPO configurable via env var in
  validate_branch_existence.py
- Remove contribute UI (View Source, Edit Page, Report Issue) since
  repo is now private
- Remove GitHub issue links from feedback widgets
- Update raw.githubusercontent.com download URLs in prod-deployment
  includes, app tutorials, and demo files
- Update community-tooling pages to remove "open a PR" language
- Fix stale Netlify preview link in v26.1.0 release notes

Tickets: EDUENG-720, EDUENG-751, EDUENG-753, EDUENG-726, EDUENG-729,
EDUENG-756, DOC-17219

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant