Add Ubuntu 26.04 (resolute) as a supported platform#413
Open
ihalatci wants to merge 3 commits into
Open
Conversation
Mirror the existing noble (Ubuntu 24.04) wiring to add resolute (Ubuntu 26.04 LTS, "Resolute Raccoon"): - common_tool_methods.py: append "resolute" to supported_platforms["ubuntu"], which is the argparse gate built by platform_names(). - citus_package.py: add "ubuntu,resolute" -> "ubuntu/resolute" to package_docker_platform_dict. - upload_to_package_cloud.py: add "ubuntu/resolute" distro_version_id placeholder -1 (TODO: real packagecloud id for Ubuntu 26.04) so uploads fail safely until filled. - test_citus_package.py + tests/test_citus_package.py: add the resolute test platform and its expected package count. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Replace the -1 placeholder for "ubuntu/resolute" with the actual packagecloud distro_version_id 320 (Ubuntu 26.04), mirroring the existing noble entry. Uploads to packagecloud can now target resolute. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…u-resolute-support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the existing
noble(Ubuntu 24.04) wiring to addresolute(Ubuntu 26.04 LTS, "Resolute Raccoon") as a supported platform. Unblocks the parallelubuntu,resolutechange in citusdata/packaging, which is CI-gated on tools'platform_names()argparse validation.Changes
common_tool_methods.py— append"resolute"tosupported_platforms["ubuntu"]. This is the core argparse gate built byplatform_names().citus_package.py— add"ubuntu,resolute": "ubuntu/resolute"topackage_docker_platform_dict.upload_to_package_cloud.py— add"ubuntu/resolute": 320(real packageclouddistro_version_idfor Ubuntu 26.04, mirroringnoble= 284). Landed initially as a loud-1placeholder, then set to the real id.test_citus_package.py— add theubuntu_resolutetest platform.tests/test_citus_package.py— add"ubuntu/resolute": 2expected package count.Testing
pytest packaging_automation/tests/test_citus_package.py(excluding docker/network tests): 5 passed, 2 deselected (test_build_packagesneeds docker + a packaging branch checkout;test_upload_to_package_cloudneeds packagecloud network — cannot run locally).black --checkclean on all changed files.platform_names()now includesubuntu/resolute.Deferred (not in this PR)
CI matrix additions (
citus-package-all-platforms-test.yml,package-tests.yml,build-citus-community-nightlies.yml) and atest-images/ubuntu-resolute/dir are intentionally left out — they trigger real docker build/install/upload and depend on published packaging recipes + published packages. These follow in a later change once the upstream pieces land.Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com