Fix buf generate clean to not delete nested output#4615
Open
doriable wants to merge 1 commit into
Open
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
timostamm
approved these changes
Jul 16, 2026
| // directories in dirOutputPaths that are nested under parentDir. Both | ||
| // parentDir and the map keys are OS-native absolute paths; the returned | ||
| // paths are normalized (forward slashes) for use with storage bucket paths. | ||
| func nestedOutputDirs(parentDir string, dirOutputPaths map[string]map[string]struct{}) map[string]struct{} { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where if a plugin writes to
the child directory of another plugin's out directory,
the file will end up being cleaned, since it is not part
of the latter plugin's output.
Instead of tracking per-directory by individual buckets
for each plugin's generated output, we track the full paths
of all generated files, and then clean based on that. A test
case has also been added for this.