Fix -Wmissing-prototypes warnings (330 -> 2)#6
Open
iav wants to merge 1 commit into
Open
Conversation
Add 'static' to file-private functions and forward declarations for cross-file functions to type-aware home headers (rtw_br_ext.h, mlme_osdep.h, osdep_intf.h, rtw_btcoex.h), plus self-includes where a declaration already existed. No functional change. The two remaining warnings (update_hidden_ssid, rtw_change_ifname) are left untouched on purpose: each collides with a config-guarded namesake or a low-level header that does not know the parameter types. Assisted-by: Claude:claude-opus-4.8
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Eliminates 328 of 330 -Wmissing-prototypes warnings emitted when the
driver is built into a modern kernel (verified on 6.18, odroidm1):
statictype-aware home header (rtw_br_ext.h, mlme_osdep.h, osdep_intf.h,
rtw_btcoex.h), or a self-include where a declaration already existed
No functional change — only linkage and declarations.
Remaining 2 warnings (left untouched on purpose)
namesake exists in hal/hal_com.c; a shared prototype would clash
not know the _adapter type
Verified
Builds cleanly into kernel 6.18 (odroidm1): 0 errors, 0 modpost issues,
warnings 330 -> 2. Applies cleanly onto current HEAD.