Add support for X88 PRO RK3566 TV box#500
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a new DTB build target and introduces rk3566-box-X88PRO-npu.dts describing the board: root model/console, GPIO IR/LED/OpenVFD, SDIO Wi‑Fi pwrseq and fixed 5V regulators, gmac1 RGMII and MDIO PHY with PMU supplies, NPU MMU change, SDHCI/SDMMC controllers (including SDIO-hosted Wi‑Fi), UART1 with Bluetooth child, USB PHY/usbdrd_dwc3 host config, PCIe combphy refclk, and comprehensive pinctrl groups. Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@arch/arm64/boot/dts/rockchip/rk3566-box-X88PRO-npu.dts`:
- Around line 204-206: The wifi@1 SDIO node currently uses compatible
"brcm,bcm4329-fmac" while the UART/Bluetooth node uses "realtek,rtl8822cs-bt",
indicating a mismatched combo-chip; verify the actual module from the vendor DTB
or boot logs and update one of the nodes so both nodes use the same
silicon-compatible string (either change wifi@1 to the Realtek compatible or
change the BT UART node to the Broadcom compatible), ensuring the two nodes
reference the identical compatible identifier (search for "brcm,bcm4329-fmac"
and "realtek,rtl8822cs-bt" to locate the exact nodes) and keep any required
properties (reg, interrupts, clks) consistent with the chosen driver binding.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5d0a972a-fafa-4e0c-8ab1-220e85b23b98
📒 Files selected for processing (2)
arch/arm64/boot/dts/rockchip/Makefilearch/arm64/boot/dts/rockchip/rk3566-box-X88PRO-npu.dts
1 participant
This PR adds a device tree for the X88 PRO TV box based on the Rockchip RK3566 SoC.
The DTS was reconstructed from the vendor Android DTB and adapted for the Rockchip/Armbian 6.1 vendor kernel.
Tested working:
Known limitations:
This is intended as initial board support for the X88 PRO / RUPA RK3566 TV box.
LSCPU:
Architecture: aarch64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian CPU(s): 4 On-line CPU(s) list: 0-3 Vendor ID: ARM Model name: Cortex-A55 Model: 0 Thread(s) per core: 1 Core(s) per cluster: 4 Socket(s): - Cluster(s): 1 Stepping: r2p0 CPU(s) scaling MHz: 23% CPU max MHz: 1800.0000 CPU min MHz: 408.0000 BogoMIPS: 48.00 Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm lrcpc d cpop asimddp Vulnerabilities: Gather data sampling: Not affected Itlb multihit: Not affected L1tf: Not affected Mds: Not affected Meltdown: Not affected Mmio stale data: Not affected Reg file data sampling: Not affected Retbleed: Not affected Spec rstack overflow: Not affected Spec store bypass: Not affected Spectre v1: Mitigation; __user pointer sanitization Spectre v2: Not affected Srbds: Not affected Tsx async abort: Not affectedstress-ng --cpu 4 --timeout 60s --metrics-brief
stress-ng: info: [2506] setting to a 1 min run per stressor stress-ng: info: [2506] dispatching hogs: 4 cpu stress-ng: metrc: [2506] stressor bogo ops real time usr time sys time bogo ops/s bogo ops/s stress-ng: metrc: [2506] (secs) (secs) (secs) (real time) (usr+sys time) stress-ng: metrc: [2506] cpu 20698 60.05 237.11 0.21 344.70 87.21 stress-ng: info: [2506] skipped: 0 stress-ng: info: [2506] passed: 4: cpu (4) stress-ng: info: [2506] failed: 0 stress-ng: info: [2506] metrics untrustworthy: 0 stress-ng: info: [2506] successful run completed in 1 minRKNN test:
rknn_api/rknnrt version: 2.3.2 (429f97ae6b@2025-04-09T09:09:27), driver version: 0.9.8 model input num: 1, output num: 1 input tensors: index=0, name=input, n_dims=4, dims=[1, 224, 224, 3], n_elems=150528, size=150528, fmt=NHWC, type=INT8, qnt_type=AFFINE, zp=0, scale=0.007812 output tensors: index=0, name=MobilenetV1/Predictions/Reshape_1, n_dims=2, dims=[1, 1001, 0, 0], n_elems=1001, size=2002, fmt=UNDEFINED, type=FP16, qnt_type=AFFINE, zp=0, scale=1.000000 custom string: Begin perf ... 0: Elapse Time = 8.06ms, FPS = 124.12 ---- Top5 ---- 0.935059 - 156 0.057037 - 155 0.003881 - 205 0.003119 - 284 0.000172 - 285Armbian forum page:
https://forum.armbian.com/topic/18255-rk3566-and-armbian/page/2/