Fix for ImageMagick 7#14
Open
dirk-zimoch wants to merge 1 commit into
Open
Conversation
ImageMagick 7 no longer has `IntegerPixel`. Instead it now defines `LongPixel` to have always 32 bits on all architectures. In ImageMagick 6, `LongPixel` had 32 or 64 bits, depending on the size of the native type `long`.
ericonr
approved these changes
Jul 3, 2026
Comment on lines
+123
to
+127
| #if MagickLibVersion >= 0x700 | ||
| storageType = LongPixel; | ||
| #else | ||
| storageType = IntegerPixel; | ||
| #endif |
Member
There was a problem hiding this comment.
I think I would prefer a solution using <type_traits> instead of hardcoding library version numbers, but it might be less understandable, so I'm okay with this version as well.
Author
There was a problem hiding this comment.
<type_traits> would require a C++11 compatible compiler. Not a very high hurdle nowadays but a new requirement.
Author
There was a problem hiding this comment.
And it IS a version dependent change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageMagick 7 no longer has
IntegerPixel. Instead it now definesLongPixelto have always 32 bits on all architectures. In ImageMagick 6,LongPixelhad 32 or 64 bits, depending on the size of the native typelong.