Remove duplicate release workflow that double-builds and races on every tag#1781
Open
radheradhe01 wants to merge 1 commit into
Open
Remove duplicate release workflow that double-builds and races on every tag#1781radheradhe01 wants to merge 1 commit into
radheradhe01 wants to merge 1 commit into
Conversation
release-build.yml is byte-identical to release.yml and triggers on the same release-tag push with no concurrency guard, so every tag starts two identical build+publish runs. Remove the later-added copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1755.
.github/workflows/release.ymland.github/workflows/release-build.ymlare byte-for-byte identical (same blob SHA) and both trigger on the same release-tag push ([0-9]+\.[0-9]+\.[0-9]+), with noconcurrency:group. So every release tag starts two identical workflow runs:common.yml,timeout-minutes: 75) runs twice; andsoftprops/action-gh-releasefor the same tag and assets, which can race.This is observable in the Actions history: both workflows ran at the identical timestamp for 1.0.0, 0.12.3, 0.12.1, 0.12.0 and 0.11.0 — and for 0.12.2 one of the two runs was
cancelledwhile the other succeeded.This change removes
release-build.yml, which was added later as a copy ofrelease.yml(#550), restoring a single release workflow.If you'd prefer to keep
release-build.ymland droprelease.ymlinstead, or keep both behind aconcurrency: { group: release-${{ github.ref }} }guard, I'm happy to switch — they're identical, so any of those resolves the double-run.