fix(curl-impersonate): Avoid false already consumed error for buffered streams in CurlImpersonateHttpClient#2042
Merged
Merged
Conversation
…ersonateHttpClient`
vdusek
changed the title
already consumed error for streamed responses in CurlImpersonateHttpClientCurlImpersonateHttpClient
vdusek
reviewed
Jul 8, 2026
Mantisus
added a commit
to Mantisus/crawlee-python
that referenced
this pull request
Jul 10, 2026
…d streams in `CurlImpersonateHttpClient` (apify#2042) ### Description - `curl_cffi` buffers a streamed response in a queue, so a small response body could be fully buffered before reading started. This caused a false `RuntimeError: Cannot read stream, it was already consumed.` from `read_stream`. ### Testing - Added new regression tests for HTTP clients
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
curl_cffibuffers a streamed response in a queue, so a small response body could be fully buffered before reading started. This caused a falseRuntimeError: Cannot read stream, it was already consumed.fromread_stream.Testing