Skip to content

test: deflake Playwright navigation tests hitting ERR_NO_BUFFER_SPACE on Windows CI#2040

Open
vdusek wants to merge 2 commits into
masterfrom
test/deflake-playwright-buffer-space
Open

test: deflake Playwright navigation tests hitting ERR_NO_BUFFER_SPACE on Windows CI#2040
vdusek wants to merge 2 commits into
masterfrom
test/deflake-playwright-buffer-space

Conversation

@vdusek

@vdusek vdusek commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Two Playwright crawler tests set max_request_retries=0 and assert that navigation succeeds. On the Windows CI runners under pytest-xdist load, Chromium navigation intermittently fails with net::ERR_NO_BUFFER_SPACE (socket-buffer exhaustion). With retries disabled, a single such spurious failure aborted the run and failed the assertions (this is what broke on the reported CI run).

Dropping max_request_retries=0 (falling back to the default of 3) lets a spurious navigation failure recover on retry, matching how the neighbouring tests already survive. The assertions are unchanged and still meaningful:

  • test_respect_robots_txt_with_problematic_linksbudplaceholder.com still reaches the failed-request handler once its retries are exhausted.
  • test_slow_navigation_does_not_count_toward_handler_timeout — a single successful attempt still yields the asserted counts.

The failure-asserting tests that intentionally rely on max_request_retries=0 (test_navigation_timeout_on_slow_page_load, test_navigation_timeout_applies_to_hooks, and the adaptive static-timeout test) were left unchanged, since enabling retries there would change their semantics rather than help.

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Jul 7, 2026
@vdusek vdusek self-assigned this Jul 7, 2026
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.36%. Comparing base (9b6ae6f) to head (eddc4dd).
⚠️ Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2040      +/-   ##
==========================================
- Coverage   93.36%   93.36%   -0.01%     
==========================================
  Files         179      179              
  Lines       12488    12495       +7     
==========================================
+ Hits        11660    11666       +6     
- Misses        828      829       +1     
Flag Coverage Δ
unit 93.36% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek requested a review from Pijukatel July 10, 2026 07:17
@vdusek vdusek marked this pull request as ready for review July 10, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants