feat: split navbar into separate API, SDK, and CLI items#2761
Open
TC-MO wants to merge 3 commits into
Open
Conversation
Replace the single "APIs, SDKs & CLI" dropdown with three right-side items: API and SDK as hover dropdowns, CLI as a plain link. Each label links to its landing page (/api, /sdk, /cli) while API/SDK still reveal their sub-links on hover, and the API dropdown groups the experimental clients under a labeled subsection. Override DropdownNavbarItem/Desktop so a dropdown label navigates on href (stock only navigates on to), since the shared navbar uses absolute hrefs for cross-repo links. Guard NavbarNavLink's active-state check against link-less items (the html subheader).
Contributor
|
✅ Preview for this PR (commit |
The right-hand navbar group used a wider gap (1.6rem) than the left (0.4rem). With only Academy plus one dropdown on the right it went unnoticed, but splitting into API, SDK, and CLI made the mismatch obvious. Match the right gap to the left so all top-nav items are evenly spaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More context in this slack thread
Replace the single "APIs, SDKs & CLI" dropdown with three right-side items: API and SDK as hover dropdowns, CLI as a plain link. Each label links to its landing page (/api, /sdk, /cli) while API/SDK still reveal their sub-links on hover, and the API dropdown groups the experimental clients under a labeled subsection.
Override
DropdownNavbarItem/Desktopso a dropdown label navigates on href (stock only navigates on to), since the shared navbar uses absolute hrefs for cross-repo links.