Update GraphBinary/GraphSON model test coverage#3526
Open
kenhuuu wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes update the model tests by removing stale tests, adding more tests for existing types and new tests for newly supported types.
For review, the tests themselves can probably largely be ignored. I was going to CTR this but I did change how CompositePDT works (uses typed Map now rather than plain JSON object) so I'm going to keep this open for a couple days in case anyone wants to look at that part in particular. If not, I'll likely just merge this in as a CTR.
VOTE +1