dropbear: rename libtomcrypt symbols to avoid NuttX collisions#3649
Merged
linguini1 merged 1 commit intoJul 20, 2026
Merged
Conversation
Contributor
|
Hello all, this PR will fix the pipeline in apache/nuttx#19209 (comment). |
Abhishekmishra2808
force-pushed
the
dropbear-ltc-symbol-rename
branch
from
July 19, 2026 05:46
d811add to
d9d3827
Compare
acassis
previously approved these changes
Jul 19, 2026
xiaoxiang781216
previously approved these changes
Jul 20, 2026
jerpelea
previously approved these changes
Jul 20, 2026
cederom
previously approved these changes
Jul 20, 2026
cederom
left a comment
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @Abhishekmishra2808, please also update cmake as requested by @xiaoxiang781216 before merge :-)
Contributor
|
ci still fails :-( |
Rename base64_encode, base64_decode, and ecc_make_key in bundled libtomcrypt to avoid duplicate symbol link errors when dropbear is built alongside netutils/codecs and NuttX crypto (e.g. sim:dropbear). Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Abhishekmishra2808
dismissed stale reviews from cederom, jerpelea, xiaoxiang781216, and acassis
via
July 20, 2026 11:55
c8be1e6
Abhishekmishra2808
force-pushed
the
dropbear-ltc-symbol-rename
branch
from
July 20, 2026 11:55
d9d3827 to
c8be1e6
Compare
Contributor
Author
|
@FelipeMdeO PTAL !! |
xiaoxiang781216
approved these changes
Jul 20, 2026
Contributor
Hello, I tested in real hardware, working properly, go ahead. |
linguini1
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename base64_encode, base64_decode, and ecc_make_key in bundled libtomcrypt to avoid duplicate symbol link errors when dropbear is built alongside netutils/codecs and NuttX crypto (e.g., sim:dropbear).
Impact
Fixes linker failures (multiple definitions of base64_encode, etc.) on dropbear configs that enable CODECS and CRYPTO. No functional change to dropbear behavior.
Testing
./tools/configure.sh sim:dropbear&&make