Skip to content

IGNITE-28863 Fix flaky GridFileDeploymentSelfTest#13330

Merged
anton-vinogradov merged 2 commits into
apache:masterfrom
wernerdv:IGNITE-28863
Jul 7, 2026
Merged

IGNITE-28863 Fix flaky GridFileDeploymentSelfTest#13330
anton-vinogradov merged 2 commits into
apache:masterfrom
wernerdv:IGNITE-28863

Conversation

@wernerdv

@wernerdv wernerdv commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@anton-vinogradov anton-vinogradov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks correct to me: the old <touch> + <zip update="yes"> trick relied on timestamp comparison (with zip's 2-second granularity), so the entry replacement could be silently skipped, leaving the jar validly signed — hence the flakiness. Unpack/replace/repack is deterministic, and since GridUriDeploymentJarVerifier goes through JarFile (name-based lookup, digest check on read), the repacked jar reliably fails verification. Also, the <delete file=...> before <zip> is load-bearing — it defeats Ant's up-to-date check, which could otherwise skip the repack.

A few minor points inline (each applies to both the .jar and the .gar sections).

Comment thread modules/extdata/uri/pom.xml Outdated
Comment thread modules/extdata/uri/pom.xml Outdated
Comment thread modules/extdata/uri/pom.xml Outdated
@ignitetcbot

Copy link
Copy Markdown
Contributor

TCBot Test Analysis

Possible Blockers (0)

No blockers found.

New Tests (0)

No new tests found.

@anton-vinogradov anton-vinogradov merged commit 6baae8d into apache:master Jul 7, 2026
7 checks passed
@wernerdv wernerdv deleted the IGNITE-28863 branch July 7, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants