IGNITE-28863 Fix flaky GridFileDeploymentSelfTest#13330
Merged
Conversation
anton-vinogradov
left a comment
Contributor
There was a problem hiding this comment.
The approach looks correct to me: the old <touch> + <zip update="yes"> trick relied on timestamp comparison (with zip's 2-second granularity), so the entry replacement could be silently skipped, leaving the jar validly signed — hence the flakiness. Unpack/replace/repack is deterministic, and since GridUriDeploymentJarVerifier goes through JarFile (name-based lookup, digest check on read), the repacked jar reliably fails verification. Also, the <delete file=...> before <zip> is load-bearing — it defeats Ant's up-to-date check, which could otherwise skip the repack.
A few minor points inline (each applies to both the .jar and the .gar sections).
anton-vinogradov
approved these changes
Jul 6, 2026
Contributor
TCBot Test Analysis
Possible Blockers (0)No blockers found. New Tests (0)No new tests found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.