Skip to content

Docs: Add missing _downcast_ns_timestamp_to_us to ArrowScan docstring#3594

Open
qzyu999 wants to merge 1 commit into
apache:mainfrom
qzyu999:fix-arrowscan-docstring
Open

Docs: Add missing _downcast_ns_timestamp_to_us to ArrowScan docstring#3594
qzyu999 wants to merge 1 commit into
apache:mainfrom
qzyu999:fix-arrowscan-docstring

Conversation

@qzyu999

@qzyu999 qzyu999 commented Jul 2, 2026

Copy link
Copy Markdown

Which issue does this PR close?

Minor documentation gap (no issue).

Rationale for this change

The ArrowScan class declares _downcast_ns_timestamp_to_us: bool | None as a class-level type annotation and documents all other attributes in the docstring, but this attribute was missing from the Attributes section.

What changes are included in this PR?

Adds one line to the ArrowScan class docstring documenting the _downcast_ns_timestamp_to_us attribute.

Are there any user-facing changes?

No.

@ebyhr ebyhr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The constant at L1767 contains "ON_WRITE", but the actual usage is on read in my understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants