HBASE-30258 Run getAllRegionLocations more times in TestMetaRegionRep…#8416
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves stability of TestMetaRegionReplicaReplication (HBASE-30258) by retrying meta-replica location lookups/reads to reduce flakiness under load-balanced meta replica selection, and by explicitly clearing a RegionServer “moved region” cache entry during the test.
Changes:
- Switches meta read-increase assertions to Hamcrest matchers and adds a
runAtMostNTimesretry helper to re-run operations until assertions pass. - Retries
doNGetsandRegionLocator#getAllRegionLocations()multiple times to reduce random miss probability in load-balance mode. - Exposes a RegionServer helper to remove a moved-region cache entry so the test doesn’t need to wait for cache expiry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestMetaRegionReplicaReplication.java | Adds retry logic and updates assertions to make meta-replica replication test less flaky. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java | Makes moved-region cache invalidation callable from the test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3347
to
3349
| public void removeFromMovedRegions(String encodedName) { | ||
| movedRegionInfoCache.invalidate(encodedName); | ||
| } |
Comment on lines
+479
to
+480
| // Same as above, we need to run it multiple times to make it stable. And numOfMetaRelicas is | ||
| // much less than HBaseTestingUtil.KEYS.length, so here we need to run more times. |
Comment on lines
+404
to
+406
| private void runAtMostNTimes(int times, Callable<?> action, Runnable assertion) throws Exception { | ||
| for (int i = 0; i < times - 1; i++) { | ||
| action.call(); |
…licaReplication to make it more stable
liuxiaocs7
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…licaReplication to make it more stable