feat: add OR pre-selection short-circuit#22979
Open
kumarUjjawal wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@neilconway do you have time to review this PR? |
Contributor
|
@kumarUjjawal I can take a look; have you run benchmarks / evaluated what the performance is like? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PreSelectionshort-circuit strategy forOR#22342.Rationale for this change
BinaryExpralready uses pre-selection forANDwhen only a small set of LHS rows can affect the final result. This adds the matching optimization forORwhen most LHS rows are already true.What changes are included in this PR?
This PR extends pre-selection short-circuiting to
OR.For
OR, the RHS is evaluated only for rows where the LHS is false. Rows where the LHS is true are filled directly as true. The existingANDpath is kept and the scatter logic is shared.Are these changes tested?
Yes
Are there any user-facing changes?
No Public API Change