fix(provider): preserve MiniMax cache by default#32524
Closed
wgu9 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
minimax team explicitly requested this to be added, maybe they have a bug on their end but we want to enable thinking by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31755
Type of change
What does this PR do?
Stops forcing
thinking: { type: "adaptive" }onto MiniMax M3 requests that use the Anthropic SDK path by default.MiniMax users reported that cache reads work when the variant is explicitly
none, but the current default path still injects adaptive thinking before any variant is selected. This makesdefaultbehave likethinking, which can burn through MiniMax token-plan quota and disable effective caching.The explicit MiniMax M3 variants remain unchanged:
nonestill sendsthinking: { type: "disabled" }thinkingstill sendsthinking: { type: "adaptive" }How did you verify your code works?
bun test test/provider/transform.test.ts --test-name-pattern "minimax m3 thinking|minimax m3 using"frompackages/opencodebun typecheckfrompackages/opencodebunx oxlint packages/opencode/src/provider/transform.ts packages/opencode/test/provider/transform.test.tsfrom repo root (existing warnings only)git diff --checkbun turbo typecheckChecklist