Fix for Issue 307 Exposed Error through an Event Emitter#308
Open
PankajPatro wants to merge 2 commits into
Open
Fix for Issue 307 Exposed Error through an Event Emitter#308PankajPatro wants to merge 2 commits into
PankajPatro wants to merge 2 commits into
Conversation
PankajPatro
changed the title
PankajPatro
changed the title
Author
|
@manfredsteyer, @marco-gallinari how do I add an assignee to this PR? |
manfredsteyer
force-pushed
the
main
branch
4 times, most recently
from
12b4330 to
6ae2fa8
Compare
manfredsteyer
force-pushed
the
main
branch
4 times, most recently
from
93c1fc5 to
18c2874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a user of the Web Component Wrapper there was no way to know if the remote element was loaded if there was an exception during the loadRemoteModule operation other than checking the console log. Added an Output Event Emitter which emits the error if it happens. The user of this component can subscribe to this error and handle if they need it for further purposes.
Fix for Issue 307