fix: inject bound CloudBeaver session for GET data-download requests#650
Merged
Merged
Conversation
Data file download uses GET (/sql_query/api/data/{session}_xxx.csv). The
Login middleware previously skipped session injection for all GET requests,
so the request reused the browser's cb-session-id, which could be stale or
inconsistent with the server-side session bound to the export task. When it
mismatched, CloudBeaver returned "Session task not found" and the web page
showed a request error, while curl with a fresh token still worked.
Inject the DMS-bound CloudBeaver session into the request cookie for GET
requests without triggering the full login flow, so the download reuses the
same session that registered the export task.
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the "request error" shown on the web page when downloading exported data, while
curlwith a fresh token works fine.Problem
Data file download uses a GET request (
/sql_query/api/data/{session}_xxx.csv). The CloudBeaverLoginmiddleware skipped session injection for all GET requests, so the download reused the browser'scb-session-id, which could be stale or inconsistent with the server-side session bound to the export task. On mismatch, CloudBeaver returnedSession task not found; the browser (axios/blob) surfaced it as a request error, whereascurl(which carried a fresh consistent session) succeeded.Fix
For GET requests, inject the DMS-bound CloudBeaver session into the request cookie without triggering the full login flow, so the download reuses the same session that registered the export task.
Test plan
cb-session-idused by the download matches the session bound to the export task.Fixes actiontech/dms-ee#930