Refresh waveform context menu after UI language changes#12232
Merged
niksedk merged 1 commit intoJul 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After changing the UI language via Options > Choose UI Language..., most controls were updated immediately, but the waveform context menu continued to use the previous language.
The updated menu text only appeared after closing and restarting Subtitle Edit.
Cause & Fix
The
AudioVisualizercontrol is reused when the main layout is rebuilt. However, its context menu was created inside thevm.AudioVisualizer == nullblock, so the menu labels were only initialized when the control was first created.The fix rebuilds the waveform context menu whenever the layout is rebuilt. The existing
AudioVisualizerinstance and its event subscriptions are preserved; only the context menu and accessible name are refreshed using the current UI language.Screenshots
2026-07-0700-27-13-ezgif.com-mute-video.mp4
2026-07-0700-27-13-ezgif.com-mute-video.1.mp4
Testing
Tested on Windows 11 x64 (local Release build).