Add non-mutating theme account alias support#7859
Open
GeorgiZhelev wants to merge 1 commit into
Open
Conversation
d4133d5 to
98c5dc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sessionIdoption.findSessionIdByAlias(alias)helper for resolving account aliases without changing the current global session.--alias/SHOPIFY_FLAG_AUTH_ALIASsupport to Shopify theme commands.theme duplicate,theme metafields pull, silent metafields pull fromtheme dev, and dev-server session refreshes.@shopify/cli-kitand@shopify/theme.Why
Theme commands could only use the globally selected CLI account session. This allows commands like:
without mutating the user's current global CLI session.
Validation
pnpm vitest run packages/cli-kit/src/private/node/session.test.ts packages/cli-kit/src/public/node/session.test.ts packages/theme/src/cli/utilities/theme-command.test.ts packages/theme/src/cli/utilities/theme-environment/dev-server-session.test.ts packages/theme/src/cli/services/metafields-pull.test.tspassed: 5 files, 98 tests.pnpm nx run theme:lintpassed.pnpm nx run cli-kit:lintpassed.git diff --checkpassed.Notes:
pnpm nx run cli-kit:type-check,pnpm nx run theme:type-check, andpnpm refresh-manifestscurrently stop in the existingcli-kitGraphiQL build/type resolution errors forh3,react-dom/server,@shopify/polaris, and@shopify/polaris-iconsbefore reaching this change's surface.~/Library/Preferences; rerunning with filesystem access passed.