Skip to content

[Tests] Remove filesystem mocks in app init command tests#7852

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mock-init-9629675890244724247
Draft

[Tests] Remove filesystem mocks in app init command tests#7852
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mock-init-9629675890244724247

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Filesystem mocking can lead to tests that don't accurately reflect real-world behavior and are brittle to changes in the underlying implementation of filesystem utilities.

WHAT is this pull request doing?

Refactors packages/app/src/cli/commands/app/init.test.ts to use real temporary directories via inTemporaryDirectory instead of mocking @shopify/cli-kit/node/fs.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 9629675890244724247 started by @gonzaloriestra

Refactored `packages/app/src/cli/commands/app/init.test.ts` to use
`inTemporaryDirectory` for real filesystem operations instead of
mocking `@shopify/cli-kit/node/fs`.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant