Skip to content

[Security] Redact SHOPIFY_API_SECRET from console output#7849

Draft
gonzaloriestra wants to merge 2 commits into
mainfrom
security-redact-api-secret-10066652050855391840
Draft

[Security] Redact SHOPIFY_API_SECRET from console output#7849
gonzaloriestra wants to merge 2 commits into
mainfrom
security-redact-api-secret-10066652050855391840

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Hardens the CLI by redacting the SHOPIFY_API_SECRET from console output when running app env show and app env pull. This reduces the risk of accidental exposure of the API secret in terminal logs, screen sharing, or CI/CD logs.

WHAT is this pull request doing?

  • Redacts SHOPIFY_API_SECRET in packages/app/src/cli/services/app/env/show.ts for both text and JSON formats.
  • Redacts SHOPIFY_API_SECRET in packages/app/src/cli/services/app/env/pull.ts when displaying the updated .env file content and the diff of changes.
  • Ensures the actual secret is still written to the .env file on disk.
  • Updates unit tests to verify the redaction.

How to test your changes?

shopify app env show
shopify app env pull

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (`patch` for bug fixes · `minor` for new features · `major` for breaking changes) and added a changeset with `pnpm changeset add`

PR created automatically by Jules for task 10066652050855391840 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant