[Security] Redact SHOPIFY_API_SECRET from console output#7849
[Security] Redact SHOPIFY_API_SECRET from console output#7849gonzaloriestra wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Hardens the CLI by redacting the
SHOPIFY_API_SECRETfrom console output when runningapp env showandapp env pull. This reduces the risk of accidental exposure of the API secret in terminal logs, screen sharing, or CI/CD logs.WHAT is this pull request doing?
SHOPIFY_API_SECRETinpackages/app/src/cli/services/app/env/show.tsfor both text and JSON formats.SHOPIFY_API_SECRETinpackages/app/src/cli/services/app/env/pull.tswhen displaying the updated.envfile content and the diff of changes..envfile on disk.How to test your changes?
shopify app env showshopify app env pullPost-release steps
Checklist
PR created automatically by Jules for task 10066652050855391840 started by @gonzaloriestra