Only treat .myshopify.io as a normalized store FQDN suffix#7847
Open
PhilippeCollin wants to merge 1 commit into
Open
Only treat .myshopify.io as a normalized store FQDN suffix#7847PhilippeCollin wants to merge 1 commit into
PhilippeCollin wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens normalizeStoreFqdn’s “already-normalized” suffix detection so that only the intended local-dev store domain .myshopify.io is treated as normalized (instead of any shopify.io-ending domain), preventing inputs like evilshopify.io from bypassing normalization.
Changes:
- Narrowed the suffix check from
shopify.ioto.myshopify.ioinnormalizeStoreFqdn. - Added targeted tests ensuring
evilshopify.io-style domains are not treated as normalized while preserving.myshopify.ioin local. - Added a changeset documenting the patch.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/cli-kit/src/public/node/context/fqdn.ts | Restricts normalized-suffix recognition to .myshopify.io (plus existing .myshopify.com/.shop.dev). |
| packages/cli-kit/src/public/node/context/fqdn.test.ts | Adds regression tests for shopify.io sibling/nested domains and a local .myshopify.io preservation test. |
| .changeset/normalize-store-fqdn-suffix.md | Records the behavior change as a patch release note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graygilmore
approved these changes
Jun 17, 2026
graygilmore
left a comment
graygilmore
left a comment
Contributor
There was a problem hiding this comment.
Makes sense. I can't think of any other *shopify.io that we'd use through here. Tbh we might even just be able to drop myshopify.io altogether but we can poke at that later.
Assisted-By: devx/6a08152b-0dac-4994-ac1a-d0471a9ed4a9
PhilippeCollin
force-pushed
the
fix-normalize-store-fqdn-suffix
branch
from
f5cde04 to
d22ad61
Compare
graygilmore
approved these changes
Jun 17, 2026
EvilGenius13
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
shopify.iosuffix check matched any domain ending inshopify.io(e.g.notshopify.io); tighten it to.myshopify.io.*.myshopify.iois the hostname the legacy local dev server assigns to stores (seedev-server-2016.ts), which is why it's treated as already-normalized.